chore: (cy.prompt) refactor routing to support both app and driver #31891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrada9166
approved these changes
Jun 13, 2025
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/update-routes-for-app-in-cy-prompt
|
| Run status |
|
| Run duration | 20m 53s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
11
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32200
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.71%
|
|
|---|---|
|
Untested elements
|
191
|
|
Tested elements
|
165
|
Accessibility
92.74%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
695
|
Tests for review
cypress/e2e/commands/prompt/prompt.cy.ts • 1 failed test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/prompt > executes the prompt command |
Test Replay
|
|
cypress/e2e/commands/prompt/prompt.cy.ts • 1 failed test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/prompt > executes the prompt command |
Test Replay
|
|
cypress/e2e/commands/prompt/prompt.cy.ts • 1 failed test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/prompt > executes the prompt command |
Test Replay
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an xhr request is canceled |
The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With the changes to add an app entry point, we now need to distinguish between the app and driver routes.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?