Skip to content

fix(frontend): add explicit handler for search form submission to pre… #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(frontend): add explicit handler for search form submission to pre… #1689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions modules/core/js_modules/route_handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,21 @@ function applySearchPageHandlers(routeParams) {
$('.search_reset').on("click", Hm_Utils.reset_search_form);
$('.combined_sort').on("change", function() { Hm_Message_List.sort($(this).val()); });

// Add explicit handler for search form submission to fix double-click issue
$('.search_update').on("click", function(e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.search_update is a submit button. We shouldn't need to emulate its behaviour of form submission. The proper fix here would be to find the reason why clicking it one time doesn't submit the form and fix that - probably other event handlers kicking in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug seems to be fixed since yesterday. I am looking for the recent PR to identify the fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: https://dev.tiki.org/How-to-figure-out-which-commit-causes-a-bug

e.preventDefault();
const form = $(this).closest('form');
if (form.length) {
const formData = new FormData(form[0]);
const params = new URLSearchParams();
for (let [key, value] of formData.entries()) {
params.append(key, value);
}
const newUrl = window.location.pathname + '?' + params.toString();
window.location.href = newUrl;
}
});

performSearch(routeParams);

if (window.inlineMessageMessageListAndSearchPageHandler) inlineMessageMessageListAndSearchPageHandler(routeParams);
Expand Down
Loading