fix(frontend): add explicit handler for search form submission to pre… #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent double-click issues
|
Super! Once it's merged in master (and thus will be part of 2.5.0 soon), please also fix in 1.4.x |
kroky
reviewed
Sep 17, 2025
| $('.combined_sort').on("change", function() { Hm_Message_List.sort($(this).val()); }); | ||
|
|
||
| // Add explicit handler for search form submission to fix double-click issue | ||
| $('.search_update').on("click", function(e) { |
There was a problem hiding this comment.
.search_update is a submit button. We shouldn't need to emulate its behaviour of form submission. The proper fix here would be to find the reason why clicking it one time doesn't submit the form and fix that - probably other event handlers kicking in?
There was a problem hiding this comment.
This bug seems to be fixed since yesterday. I am looking for the recent PR to identify the fix
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task
Added explicit click handler for
.search_updatebutton inroute_handlers.jsto ensure search works on first click.