egress: Add new iptabels rule for dropping invalid packets #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
chez-shanpu
reviewed
May 30, 2025
v2/pkg/founat/egress.go
Outdated
Comment on lines
79
to
82
| err = ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err) | ||
| } |
There was a problem hiding this comment.
Suggested change
| err = ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP") | |
| if err != nil { | |
| return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err) | |
| } | |
| if err := ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP"); err != nil { | |
| return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err) | |
| } |
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new iptables rule in egress NAT pods to drop invalid packets.
The specific added rule is here.
Signed-off-by: terashima tomoya-terashima@cybozu.co.jp