Introduce egress metrics to count invalid packets and bytes #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
terassyi
force-pushed
the
add-egress-metrics-for-invalid-packets
branch
from
91d770f to
9e6ffaf
Compare
Signed-off-by: Hiroki Hanada <hiroki-hanada@cybozu.co.jp>
yokaze
requested changes
Jun 10, 2025
Signed-off-by: terashima <terashima-tomoya@cybozu.co.jp>
|
I've added the document. About tests, we don't have any tests for ergess pod's metrics now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up PR of #329.
We introduce following metrics.
coil_egress_nftables_invalid_packets_totalcoil_egress_nftables_invalid_bytes_totalSigned-off-by: terashima tomoya-terashima@cybozu.co.jp