New Spanish language added via upload #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Spanish language added
Vovan-VE
requested changes
Aug 10, 2024
There was a problem hiding this comment.
It's my fail to not mention ICU syntax in README. Sorry for that.
In general, all the "keys" in select and plural must be untouched, and all of then must include other key, even if empty other{}, or formatting will raise an error. Check any existing translations for reference (same filename same line number), better non-familar language.
Hello, I made the corrections. I also reviewed 4 more files. Thank you for the indications
|
@antoromani , Thanks for contribution! Sorry for delay, I will check it as soon as possible. |
|
@antoromani , language published. Thanks for contribution! Feel free to collect remarks, if you will find some, to open new PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Spanish language added, please review