Skip to content

Fix BOF #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

Fix BOF #1851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion contrib/seccomp-receiver/seccomp-receiver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ open_unix_domain_socket (const char *path)
int fd = socket (AF_UNIX, SOCK_STREAM, 0);
if (fd < 0)
error (EXIT_FAILURE, errno, "error creating UNIX socket");


if (strlen (path) >= sizeof (addr.sun_path))
error (EXIT_FAILURE, 0, "invalid path");
Comment on lines +51 to +52
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: The error message for an invalid path could be more descriptive.

Consider adding the invalid path or its length to the error message for better debugging context.

Suggested change
if (strlen (path) >= sizeof (addr.sun_path))
error (EXIT_FAILURE, 0, "invalid path");
if (strlen (path) >= sizeof (addr.sun_path))
error (EXIT_FAILURE, 0, "invalid path: '%s' (length: %zu, max: %zu)", path, strlen(path), sizeof(addr.sun_path) - 1);


strcpy (addr.sun_path, path);
addr.sun_family = AF_UNIX;
ret = bind (fd, (struct sockaddr *) &addr, sizeof (addr));
Expand Down