Fix BOF

[Abdullah-Ebryx]

Summary by Sourcery

Prevent buffer overflow when creating UNIX domain socket by validating the path length before copying into sun_path in seccomp-receiver.

Bug Fixes:

• Add check to ensure the socket path length is less than sun_path capacity before strcpy
• Return error if the provided path is too long

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure the UNIX domain socket path cannot overflow its buffer by validating its length before copying and exiting with an error on failure.

File-Level Changes

Change	Details	Files
Validate path length to prevent BOF in UNIX socket path	Inserted a check that strlen(path) must be less than sizeof(addr.sun_path) Call error(EXIT_FAILURE, 0, "invalid path") when the path is too long	contrib/seccomp-receiver/seccomp-receiver.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Abdullah-Ebryx - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `contrib/seccomp-receiver/seccomp-receiver.c:52` </location>
<code_context>
-
+  
+  if (strlen (path) >= sizeof (addr.sun_path))
+    error (EXIT_FAILURE, 0, "invalid path");
+    
   strcpy (addr.sun_path, path);
</code_context>

<issue_to_address>
The error message for an invalid path could be more descriptive.

Consider adding the invalid path or its length to the error message for better debugging context.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
  if (strlen (path) >= sizeof (addr.sun_path))
    error (EXIT_FAILURE, 0, "invalid path");
=======
  if (strlen (path) >= sizeof (addr.sun_path))
    error (EXIT_FAILURE, 0, "invalid path: '%s' (length: %zu, max: %zu)", path, strlen(path), sizeof(addr.sun_path) - 1);
>>>>>>> REPLACE

</suggested_fix>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: The error message for an invalid path could be more descriptive.

Consider adding the invalid path or its length to the error message for better debugging context.

Suggested change

	if (strlen (path) >= sizeof (addr.sun_path))
	error (EXIT_FAILURE, 0, "invalid path");
	if (strlen (path) >= sizeof (addr.sun_path))
	error (EXIT_FAILURE, 0, "invalid path: '%s' (length: %zu, max: %zu)", path, strlen(path), sizeof(addr.sun_path) - 1);

[giuseppe]

LGTM