Skip to content

Fix eslint config #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix eslint config #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ const config = {
"plugin:import/typescript",
"prettier",
],
rules: {
...vitest.configs.recommended.rules,
},
settings: {
jsdoc: {
mode: "typescript",
Expand All @@ -57,6 +54,7 @@ const config = {
},
},
rules: {
...vitest.configs.recommended.rules,
"eslint-comments/no-unused-enable": "error",
"eslint-comments/no-unused-disable": "error",
"eslint-comments/no-aggregating-enable": "off",
Expand Down
1 change: 1 addition & 0 deletions packages/connect-query/src/use-infinite-query.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ describe("useSuspenseInfiniteQuery", () => {
expect(result.current.isFetching).toBeFalsy();
});

// eslint-disable-next-line vitest/expect-expect -- We are asserting via @ts-expect-error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm run all still passes when I remove @ts-expect-error 🙈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out #428 has type errors then went unnoticed because of this issue.

CI should definitely catch type errors in tests. WDYT, @paul-sachs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i'll take a look and see what needs to be fixed here.

it("does not allow excess properties", () => {
renderHook(
() => {
Expand Down