Fix eslint config #429
Merged
Fix eslint config #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
force-pushed
the
tstamm/Fix-eslint-config
branch
from
9bfe452 to
bbdda28
Compare
timostamm
commented
Sep 30, 2024
| @@ -375,6 +375,7 @@ describe("useSuspenseInfiniteQuery", () => { | |||
| expect(result.current.isFetching).toBeFalsy(); | |||
| }); | |||
|
|
|||
| // eslint-disable-next-line vitest/expect-expect -- We are asserting via @ts-expect-error | |||
There was a problem hiding this comment.
pnpm run all still passes when I remove @ts-expect-error 🙈
There was a problem hiding this comment.
Turns out #428 has type errors then went unnoticed because of this issue.
CI should definitely catch type errors in tests. WDYT, @paul-sachs
There was a problem hiding this comment.
Yeah, i'll take a look and see what needs to be fixed here.
paul-sachs
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.