Skip to content

clean unnecessary copy #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

clean unnecessary copy #469

merged 3 commits into from
Mar 20, 2025

Conversation

rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Mar 17, 2025 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (802f56c) to head (0748500).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   78.72%   78.71%   -0.01%     
==========================================
  Files          50       50              
  Lines        2468     2467       -1     
==========================================
- Hits         1943     1942       -1     
  Misses        473      473              
  Partials       52       52
Files with missing lines Coverage Δ
pkg/cluster/service.go 79.05% <ø> (-0.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fbm3307
fbm3307 reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work 🚀, Thank you for fixing this,

Just curious on how did you find these occurrences.(or may be how do we make sure if we have removed all such occurrences)
Also, can you please also add the PR links of other related PR too?

@rsoaresd
Copy link
Contributor Author

Great Work 🚀, Thank you for fixing this,

Just curious on how did you find these occurrences.(or may be how do we make sure if we have removed all such occurrences) Also, can you please also add the PR links of other related PR too?

I found through grep -rE '\b(\w+)\s*:=\s*\1\b' . 😅

Sure!

This was referenced Mar 18, 2025
Merged
Merged
Merged
Merged
mfrancisc
mfrancisc approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rsoaresd rsoaresd merged commit 64a9a8d into codeready-toolchain:master Mar 20, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@xcoulon xcoulon xcoulon approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@mfrancisc mfrancisc mfrancisc approved these changes

@fbm3307 fbm3307 fbm3307 approved these changes

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek

@rajivnathan rajivnathan Awaiting requested review from rajivnathan

@ranakan19 ranakan19 Awaiting requested review from ranakan19

@jrosental jrosental Awaiting requested review from jrosental

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rsoaresd @metlos @xcoulon @alexeykazakov @mfrancisc @fbm3307