clean unnecessary copy #1157
Merged
clean unnecessary copy #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsoaresd
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
fbm3307,
metlos and
jrosental
as code owners
xcoulon
approved these changes
Mar 17, 2025
alexeykazakov
approved these changes
Mar 17, 2025
This was referenced Mar 18, 2025
mfrancisc
approved these changes
Mar 18, 2025
fbm3307
approved these changes
Mar 18, 2025
metlos
approved these changes
Mar 19, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, fbm3307, metlos, mfrancisc, rsoaresd, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 83.75% 83.74% -0.01%
==========================================
Files 82 82
Lines 7933 7931 -2
==========================================
- Hits 6644 6642 -2
Misses 1092 1092
Partials 197 197
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clean unnecessary copy. With go 1.22, we do not need it. For more info, check https://go.dev/blog/loopvar-preview
clean unnecessary copy toolchain-e2e#1133
clean unnecessary copy member-operator#641
clean unnecessary copy kubesaw/ksctl#108
clean unnecessary copy toolchain-common#469
was pr 149