upgrade sdk and kubebuilder for openshift 4.17

[rsoaresd]

Description

We already did the first phase of PRs to upgrade the dependencies for openshift 4.17. Now the second phase is to actually upgrade operator-sdk and kubebuilder. The following docs were followed:

• https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/

  • We can use our current approach and change the metrics service in the future if we decide to do so. On the doc, they say that the changes are done due to kube-rbac-proxy being deprecated in kubebuilder. But since we do not use gcr.io/kubebuilder/kube-rbac-proxy, we are good for now
  • I did not include comment-spacings in revive because it would hit a lot of issues due to //+kubebuilder

• https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4

  • only main.go was moved for cmd/main.go due to following best practices, other structure changes will be consider in the future

Tool/Library	Current Version	Updates to Version
Operator SDK	1.36	1.38
kubebuilder	v3	v4

Related PRs:

• upgrade operator-sdk to 1.38 toolchain-cicd#136
• upgrade operator-sdk and kubebuilder for openshift 4.17 host-operator#1160

Issue ticket number and link

SANDBOX-808

[rsoaresd]

temporary until codeready-toolchain/toolchain-cicd#136 is merged / ensure that nothing breaks

[rsoaresd]

"dummy" file because without it was failing with:

Error: accumulating resources: accumulation err='accumulating resources from '../samples': '/Users/rsoaresd/member-operator/config/samples' must resolve to a file': couldn't make target for path '/Users/rsoaresd/member-operator/config/samples': kustomization.yaml is empty

[alexeykazakov]

this /samples/ thing doesn't really applied anyway, right? IT's more for documentation purposes?

[rsoaresd]

Yes, they serve as "examples of Custom Resources that can be applied to the cluster"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (04e5ca3) to head (db2ada7).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   76.02%   80.69%   +4.66%     
==========================================
  Files          46       45       -1     
  Lines        4476     4217     -259     
==========================================
  Hits         3403     3403              
+ Misses        923      664     -259     
  Partials      150      150              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[alexeykazakov]

Looks good. Just don't forget to update OWNER_AND_BRANCH_LOCATION=rsoaresd/toolchain-cicd/openshift_4_17_cicd before merging! :)

[mfrancisc]

Looks good 👍 Thank you!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, metlos, mfrancisc, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,fbm3307,metlos,mfrancisc,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rsoaresd]

/retest

it seems flaky test

        ----
        diffs:
        expected Space to match the state label value: pending 
        actual labels: map[toolchain.dev.openshift.com/appstudio-tier-hash:943541ec40be180bc9cfe4751d3d3a76 toolchain.dev.openshift.com/state:cluster-assigned]
        expected conditions to match:
        
        expected:
        ----
        {Ready False 0001-01-01 00:00:00 +0000 UTC ProvisioningPending unspecified target member cluster <nil>}----
        actual:
        ----
        [{Ready True 2025-03-20 14:04:41 +0000 UTC Provisioned  <nil>}]----
        -expected
        +actual
          any(
        - 	v1alpha1.Condition{
        - 		Type:    "Ready",
        - 		Status:  "False",
        - 		Reason:  "ProvisioningPending",
        - 		Message: "unspecified target member cluster",
        - 	},
        + 	[]v1alpha1.Condition{
        + 		{
        + 			Type:               "Ready",
        + 			Status:             "True",
        + 			LastTransitionTime: s"2025-03-20 14:04:41 +0000 UTC",
        + 			Reason:             "Provisioned",
        + 		},
        + 	},
          )
        
        And having the LastTransitionTime 2025-03-20 14:08:39.754361931 +0000 UTC m=+413.421191829 or older
        

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.8% Duplication on New Code

See analysis details on SonarQube Cloud