upgrade operator-sdk and kubebuilder for openshift 4.17

[rsoaresd]

Description

We already did the first phase of PRs to upgrade the dependencies for openshift 4.17. Now the second phase is to actually upgrade operator-sdk and kubebuilder. The following docs were followed:

• https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/

  • We can use our current approach and change the metrics service in the future if we decide to do so. On the doc, they say that the changes are done due to kube-rbac-proxy being deprecated in kubebuilder. But since we do not use gcr.io/kubebuilder/kube-rbac-proxy, we are good for now
  • I did not include comment-spacings in revive because it would hit a lot of issues due to //+kubebuilder

• https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4

  • only main.go was moved for cmd/main.go due to following best practices, other structure changes will be consider in the future

Tool/Library	Current Version	Updates to Version
Operator SDK	1.36	1.38
kubebuilder	v3	v4

Related PRs:

• upgrade operator-sdk to 1.38 toolchain-cicd#136
• upgrade sdk and kubebuilder for openshift 4.17 member-operator#645

Issue ticket number and link

SANDBOX-808

[rsoaresd]

temporary until codeready-toolchain/toolchain-cicd#136 is merged / ensure that nothing breaks

[metlos]

LGTM and I trust you not to forget about updating the reference to your own fork of toolchain-cicd 😃

[fbm3307]

There is a flaky unit test case, i did come across this in one of my PRs.
FAIL: TestUserSignupWithAutoApprovalWithoutTargetCluster (0.01s) counter.go:140: toolchainStatus members: [{http://api.devcluster.openshift.com/ member1 0 {<nil> <nil> <nil> <nil> [] {map[master:65 worker:68]} <nil>}}] counter.go:140: toolchainStatus members: [] metric.go:40: Error Trace: /home/runner/go/pkg/mod/github.com/codeready-toolchain/toolchain-common@v0.0.0-20250313203311-0bce6563576f/pkg/test/metrics/metric.go:40 /home/runner/work/host-operator/host-operator/controllers/usersignup/usersignup_controller_test.go:559 Error: Not equal: expected: 0x1 actual : 0x0 Test: TestUserSignupWithAutoApprovalWithoutTargetCluster

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, metlos, mfrancisc, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,fbm3307,metlos,mfrancisc,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rsoaresd]

There is a flaky unit test case, i did come across this in one of my PRs. FAIL: TestUserSignupWithAutoApprovalWithoutTargetCluster (0.01s) counter.go:140: toolchainStatus members: [{http://api.devcluster.openshift.com/ member1 0 {<nil> <nil> <nil> <nil> [] {map[master:65 worker:68]} <nil>}}] counter.go:140: toolchainStatus members: [] metric.go:40: Error Trace: /home/runner/go/pkg/mod/github.com/codeready-toolchain/toolchain-common@v0.0.0-20250313203311-0bce6563576f/pkg/test/metrics/metric.go:40 /home/runner/work/host-operator/host-operator/controllers/usersignup/usersignup_controller_test.go:559 Error: Not equal: expected: 0x1 actual : 0x0 Test: TestUserSignupWithAutoApprovalWithoutTargetCluster

@fbm3307 I did not see that flaky test in this pr. Can you point me to the job pls?

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (825a78b) to head (f6fe535).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
+ Coverage   79.71%   83.73%   +4.01%     
==========================================
  Files          83       82       -1     
  Lines        8333     7933     -400     
==========================================
  Hits         6643     6643              
+ Misses       1493     1093     -400     
  Partials      197      197              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.