fix: show unfortunately text only for outside Oregon selection #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed condition from `city ?` to `city === "other" ?` - Oregon cities now keep welcome message during loading (no flash) - Outside Oregon selection shows "Unfortunately..." text immediately - Fixes issue where all city selections showed unfortunately message Co-authored-by: Kent Shikama <KentShikama@users.noreply.github.com>
|
Yeah! This certainly works. 👍 Given we have just cities in Oregon, Oregon at large, and an "others" category at the moment, think we can go with this solution. We could come back to this later if we end up expanding this to other states. |
leekahung
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
This PR fixes the location selection text flashing issue by ensuring that only selections outside of Oregon show the "Unfortunately..." message immediately, while Oregon cities maintain the welcome message during loading.
Changes
{city ?to{city === "other" ?How It Works
Generated with Claude Code