fix: keep location selection text unchanged during loading #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isLoading state to track chat initialization - Update text rendering logic to prevent flashing - Text remains as welcome message during loading state - Only shows different text after loading completes Co-authored-by: Kent Shikama <KentShikama@users.noreply.github.com>
|
The version here seems to keep getting stuck at the welcome message. Screen.Recording.2025-06-19.at.9.47.47.PM.mov |
leekahung
reviewed
Jun 20, 2025
| @@ -30,10 +30,12 @@ interface Props { | |||
|
|
|||
| export default function CitySelectField({ setMessages }: Props) { | |||
| const [city, setCity] = useState<string | null>(null); | |||
| const [isLoading, setIsLoading] = useState(false); | |||
There was a problem hiding this comment.
Think I've got a fix.
Instead of calling another state, we can define selectedCity outside handleCityChange. Something like:
const selectedCity = city
? CitySelectOptions[city as keyof typeof CitySelectOptions]
: null;
Which keeps selectedCity null until city changes from setCity.
We can keep Line 39, but change it to a different name like selected to avoid clashing with selectedCity.
We could then switch up the condition in Line 67 to selectedCity === null || selectedCity.state given we switch up the order of the ternary:
{selectedCity === null || selectedCity.state
? "Welcome to Tenant First Aid! I can answer your questions about tenant rights in Oregon. To get started, what city are you located in."
: "Unfortunately we can only answer questions about tenant rights in Oregon right now."}
Screen.Recording.2025-06-19.at.10.43.13.PM.mov
This should patch things up.
There was a problem hiding this comment.
Would #139 work? I gave it a test and it seems to. I'm not sure if I'm missing some nuance though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
This PR refines the previous fix for the location selection text flashing issue. Instead of showing different text during loading, the text now remains unchanged until the chat initialization is complete.
Changes
isLoadingstate to track chat initializationHow It Works
isLoadingbecomes true, text stays unchangedisLoadingbecomes false, shows appropriate messageThis eliminates the visual flash that occurred when text changed immediately upon city selection.
Generated with Claude Code