-
Notifications
You must be signed in to change notification settings - Fork 5
chore: This is a test #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,32 @@ | ||||||||||||||||||||||
name: Bug Prediction (Overwatch) | ||||||||||||||||||||||
|
||||||||||||||||||||||
on: | ||||||||||||||||||||||
pull_request: | ||||||||||||||||||||||
types: | ||||||||||||||||||||||
- opened | ||||||||||||||||||||||
- synchronize | ||||||||||||||||||||||
|
||||||||||||||||||||||
permissions: | ||||||||||||||||||||||
contents: read | ||||||||||||||||||||||
|
||||||||||||||||||||||
jobs: | ||||||||||||||||||||||
upload-overwatch: | ||||||||||||||||||||||
runs-on: ubuntu-latest | ||||||||||||||||||||||
steps: | ||||||||||||||||||||||
- name: Checkout | ||||||||||||||||||||||
uses: actions/checkout@v4 | ||||||||||||||||||||||
|
||||||||||||||||||||||
- name: Install Overwatch CLI | ||||||||||||||||||||||
run: | | ||||||||||||||||||||||
curl -o overwatch-cli https://overwatch.codecov.io/linux/cli | ||||||||||||||||||||||
chmod +x overwatch-cli | ||||||||||||||||||||||
Comment on lines
+19
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The workflow downloads an executable binary from an external URL without any integrity verification. This poses a significant security risk as the binary could be tampered with or compromised. Consider adding checksum verification or using a signed binary distribution method.
Suggested change
Did we get this right? 👍 / 👎 to inform future reviews. |
||||||||||||||||||||||
# Using --upload-empty-on-error flag to force this step through. | ||||||||||||||||||||||
# This workflow is a temporary workaround until this alpha feature | ||||||||||||||||||||||
# is merged into AI PR review | ||||||||||||||||||||||
- name: Run Overwatch CLI | ||||||||||||||||||||||
run: | | ||||||||||||||||||||||
./overwatch-cli \ | ||||||||||||||||||||||
--auth-token ${{ secrets.OVERWATCH_SENTRY_AUTH_TOKEN }} \ | ||||||||||||||||||||||
--organization-slug codecov \ | ||||||||||||||||||||||
--upload-empty-on-error \ | ||||||||||||||||||||||
typescript --package-manager pnpm --eslint-pattern src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is missing concurrency controls which could lead to multiple instances running simultaneously on the same PR when multiple commits are pushed quickly. This could waste CI resources and potentially cause conflicts.
Did we get this right? 👍 / 👎 to inform future reviews.