-
Notifications
You must be signed in to change notification settings - Fork 5
chore: This is a test #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will decrease total bundle size by 3.36kB (-0.04%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/example-astro-5-app-server-esmAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-astro-app-server-esmAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
view changes for bundle: @codecov/vite-plugin-esmAssets Changed:
|
Bundle ReportChanges will decrease total bundle size by 1.96kB (-0.02%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-astro-app-server-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-esmAssets Changed:
view changes for bundle: @codecov/vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-astro-5-app-server-esmAssets Changed:
|
@sentry review |
- name: Install Overwatch CLI | ||
run: | | ||
curl -o overwatch-cli https://overwatch.codecov.io/linux/cli | ||
chmod +x overwatch-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow downloads an executable binary from an external URL without any integrity verification. This poses a significant security risk as the binary could be tampered with or compromised. Consider adding checksum verification or using a signed binary distribution method.
- name: Install Overwatch CLI | |
run: | | |
curl -o overwatch-cli https://overwatch.codecov.io/linux/cli | |
chmod +x overwatch-cli | |
- name: Install Overwatch CLI | |
run: | | |
curl -o overwatch-cli https://overwatch.codecov.io/linux/cli | |
# Verify checksum (example) | |
echo "expected_sha256_hash overwatch-cli" | sha256sum -c | |
chmod +x overwatch-cli |
Did we get this right? 👍 / 👎 to inform future reviews.
name: Bug Prediction (Overwatch) | ||
|
||
on: | ||
pull_request: | ||
types: | ||
- opened | ||
- synchronize | ||
|
||
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is missing concurrency controls which could lead to multiple instances running simultaneously on the same PR when multiple commits are pushed quickly. This could waste CI resources and potentially cause conflicts.
name: Bug Prediction (Overwatch) | |
on: | |
pull_request: | |
types: | |
- opened | |
- synchronize | |
permissions: | |
contents: read | |
name: Bug Prediction (Overwatch) | |
on: | |
pull_request: | |
types: | |
- opened | |
- synchronize | |
concurrency: | |
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |
cancel-in-progress: true | |
permissions: | |
contents: read |
Did we get this right? 👍 / 👎 to inform future reviews.
Description
Code Example
Notable Changes
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.