-
-
Couldn't load subscription status.
- Fork 225
feat(elasticache-redis): add engine input for valkey support #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
9450990 to
d6c744d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enumerate the legal values of engine in the variable description. Please also provide, in the README, an explanation of what they mean, with one or more links to even more information.
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
Thanks for reviewing. I'll add this now. |
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
|
@Nuru changes addressed, please re-review. |
what
why
Notes
local.cluster_attributesand add a variable to the component, default it toredis, and pass as an argument to the module as-isengine = var.enginein thelocal.var.redis_clustersto supplyenginewith a default forredisand pass to module as-islocal.cluster_attributesto overwrite itreferences