Skip to content

feat(elasticache-redis): add snapshot retention limit #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2024
Merged

feat(elasticache-redis): add snapshot retention limit #1171

merged 2 commits into from
Nov 4, 2024

Conversation

@nitrocode
Copy link
Member

@nitrocode nitrocode commented Oct 30, 2024 •
edited
Loading

what

  • add snapshot retention limit

why

  • Resolves ElastiCache.1 (ElastiCache (Redis OSS) clusters should have automatic backups enabled) securityhub control by giving the ability to set this value to a number greater than 0

references

@nitrocode nitrocode requested review from a team as code owners October 30, 2024 20:34
@nitrocode nitrocode changed the title feat(elasticache): add snapshot retention limit feat(elasticache-redis): add snapshot retention limit Oct 30, 2024
@nitrocode
feat(elasticache): add snapshot retention limit
1014808 
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode nitrocode force-pushed the elasticache-snapshot-retention-limit branch from c75d03b to 1014808 Compare October 30, 2024 20:46
@GabisCampana
Copy link

@Nuru

Nuru
Nuru requested changes Nov 1, 2024
View reviewed changes
@nitrocode @Nuru
fix: change type
a844037 
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
@nitrocode nitrocode requested a review from Nuru November 2, 2024 00:34
@Nuru Nuru merged commit f85ec61 into cloudposse:main Nov 4, 2024
4 checks passed
@nitrocode nitrocode deleted the elasticache-snapshot-retention-limit branch November 4, 2024 18:55
goruha pushed a commit to cloudposse-terraform-components/aws-elasticache-redis that referenced this pull request Nov 27, 2024
@nitrocode
feat(elasticache-redis): add snapshot retention limit (cloudposse/ter…
5c65f95 
…raform-aws-components#1171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nuru Nuru Nuru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitrocode @GabisCampana @Nuru