-
-
Notifications
You must be signed in to change notification settings - Fork 0
Bugfix: Providers tf ref #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe source reference for the "iam_roles" module in the Terraform configuration was modified by removing the "tags/" prefix from the version string, changing it from "tags/v1.535.3" to "v1.535.3". No other logic or structural changes were made. Changes
Sequence Diagram(s)No sequence diagram generated due to the simplicity of the change. Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/modules/datadog_keys/providers.tf (1)
18-18
: Optional: Make SCM protocol explicit
To ensure Terraform clones via Git and avoid any ambiguity, consider adding thegit::https://
prefix:-source = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=v1.535.3" +source = "git::https://github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=v1.535.3"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/modules/datadog_keys/providers.tf
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: component / terraform / Lint (./src)
- GitHub Check: component / terraform / Lint (./src/modules/datadog_keys)
- GitHub Check: component / terraform / bats
🔇 Additional comments (1)
src/modules/datadog_keys/providers.tf (1)
18-18
: Correct Git reference by removingtags/
prefix
The updated source URL now directly references tagv1.535.3
, which aligns with Terraform’s expected format for GitHub module sources.Please run this script to confirm that the
v1.535.3
tag exists on GitHub:#!/bin/bash # Verify that the tag v1.535.3 exists on GitHub curl -s -o /dev/null -w "%{http_code}\n" \ https://api.github.com/repos/cloudposse-terraform-components/aws-account-map/git/refs/tags/v1.535.3Expect a
200
HTTP status code if the tag is present.
These changes were released in v1.535.3. |
This pull request includes a minor change to the
src/modules/datadog_keys/providers.tf
file. The change updates thesource
URL for theiam_roles
module to remove thetags/
prefix in the version reference.Refs
Summary by CodeRabbit