Skip to content

Remove tags prefix #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

Remove tags prefix #34

merged 3 commits into from
Jun 19, 2025

Conversation

goruha
Copy link
Contributor

@goruha goruha commented Jun 19, 2025

what

  • The change updates the source URL for modules to remove the tags/ prefix in the version reference.

why

  • Terraform handles incorrectly git paths which have slashes in ref parameter

references

Summary by CodeRabbit

  • Chores
    • Updated external module sources to use specific remote GitHub repository references and version tags instead of local paths or previous tag formats. No changes to functionality or configuration.

Copy link

coderabbitai bot commented Jun 19, 2025

Walkthrough

The changes update Terraform module source references in two files. The datadog_configuration module's source ref is modified to remove the tags/ prefix, and the iam_roles module source is switched from a local path to a specific versioned remote GitHub repository. No logic or configuration changes are introduced.

Changes

Files Change Summary
src/provider-datadog.tf Updated datadog_configuration module source to remove tags/ prefix from GitHub ref.
src/providers.tf Changed iam_roles module source from local path to remote GitHub repository at version v1.535.3.

Possibly related PRs

  • Fix datadog provider configuration #30: Updates the source reference for the datadog_configuration module to use a remote GitHub repository with a version tag, similar to the changes in this PR.

Poem

A rabbit hops from path to tag,
Remote refs fetched—no need to lag!
Modules now from GitHub's store,
Precise and tidy, nothing more.
With every hop, the code aligns—
The Terraform garden neatly shines!
🐇🌱


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78f2f2b and 59cd17b.

📒 Files selected for processing (2)
  • src/provider-datadog.tf (1 hunks)
  • src/providers.tf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary
🔇 Additional comments (2)
src/provider-datadog.tf (1)

2-2: Remove tags/ prefix from Terraform module source
Aligns the ref parameter with Terraform’s VCS handling to avoid go-getter issues.

src/providers.tf (1)

17-17: Source remote IAM roles module and drop tags/ prefix
Switching to the GitHub repo with an explicit version avoids local-relative paths and fixes the prefixed tag issue.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot requested review from a team June 19, 2025 16:20
@mergify mergify bot added triage Needs triage needs-test Needs testing labels Jun 19, 2025
Copy link

mergify bot commented Jun 19, 2025

💥 This pull request now has conflicts. Could you fix it @goruha? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jun 19, 2025
@goruha goruha enabled auto-merge June 19, 2025 17:04
@mergify mergify bot removed the conflict This PR has conflicts label Jun 19, 2025
@goruha goruha added this pull request to the merge queue Jun 19, 2025
@mergify mergify bot removed the triage Needs triage label Jun 19, 2025
Merged via the queue into main with commit 8a465cc Jun 19, 2025
14 checks passed
@goruha goruha deleted the remove-tags-prefix branch June 19, 2025 17:08
Copy link

These changes were released in v1.535.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants