Skip to content

Extract object_pool module from PagePool #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Extract object_pool module from PagePool #2920

merged 1 commit into from
Jul 4, 2025

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jul 4, 2025 •
edited
Loading

Description of Changes

Extracts out Pool<T> from PagePool to facilitate defining BsatnRowListBuilderPoool, as done in the next PR #2911.

API and ABI breaking changes

None

Expected complexity level and risk

2?

Testing

  • The tests for page pools have been split into the part concerning generic pools and and the part only concerning pages.

@Centril Centril mentioned this pull request Jul 4, 2025
Merged
@Centril Centril changed the base branch from master to centril/extract-memory-usage July 4, 2025 10:02
@Centril Centril marked this pull request as ready for review July 4, 2025 10:12
@Centril Centril requested a review from kim July 4, 2025 10:12
kim
kim approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could be reused in spacetimedb_snapshot::remote

@Centril Centril force-pushed the centril/extract-memory-usage branch from f649f31 to cf2cfde Compare July 4, 2025 12:34
@Centril Centril force-pushed the centril/object-pool branch from 57862ef to fa008fb Compare July 4, 2025 12:36
Base automatically changed from centril/extract-memory-usage to master July 4, 2025 13:15
@Centril Centril force-pushed the centril/object-pool branch from fa008fb to 9411e5e Compare July 4, 2025 13:27
@Centril Centril enabled auto-merge July 4, 2025 13:40
@Centril Centril added this pull request to the merge queue Jul 4, 2025
Merged via the queue into master with commit 6a8cd7e Jul 4, 2025
18 of 19 checks passed
@Centril Centril deleted the centril/object-pool branch July 4, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim kim kim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Centril @kim