Extract spacetimedb-memory-usage & Nix bindings dep on spacetimedb-data-structures
#2919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
approved these changes
Jul 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Centril
force-pushed
the
centril/extract-memory-usage
branch
from
f649f31 to
cf2cfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The trait
MemoryUsageis moved to its own crate (spacetimedb-memory-usage) to facilitate extracting outPool<T>fromPagePoolas done in the next PR #2920. Having more small crates is a great thing. This is also done to get rid of some dependencies ofspacetimedb(crates/bindings).Preparatory work extracted from #2911.
API and ABI breaking changes
None
Expected complexity level and risk
2, this is mostly just code motion.
Testing
Covered by existing tests.