[ENH] Add impl to stop indexing when metadata index set to false

[jairad26]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • ...
• New functionality
  • ...

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jairad26]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [ENH] Add impl to stop indexing when metadata index set to false #5060 👈 (View in Graphite)
• [ENH] Add schema support to collection configuration #4932
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[blacksmith-sh]

8 Jobs Failed:

PR checks / Rust tests / test (blacksmith-8vcpu-ubuntu-2204)

No logs available for this step.

PR checks / Rust tests / test-long

Step "Test" from job "Rust tests / test-long" is failing. The last 20 log lines are:

[...]
103  |         tenant: &str,
     |         ------------
104  |         database_id: &DatabaseUuid,
     |         --------------------------
105  |         segment: &Segment,
     |         -----------------
106  |         blockfile_provider: &BlockfileProvider,
     |         --------------------------------------
107  |         schema: Option<HashMap<String, HashMap<ValueType, CollectionSchema>>>,
     |         ---------------------------------------------------------------------
help: provide the argument
     |
1885 |         let mut metadata_writer = MetadataSegmentWriter::from_segment(&tenant, &database_id, &metadata_segment, &blockfile_provider, /* std::option::Option<std::collections::HashMap<std::string::String, std::collections::HashMap<chroma_types::ValueType, CollectionSchema>>> */)
     |                                                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

For more information about this error, try `rustc --explain E0061`.
error: could not compile `chroma-segment` (lib test) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...
error: command `/home/runner/.rustup/toolchains/1.81.0-x86_64-unknown-linux-gnu/bin/cargo test --no-run --message-format json-render-diagnostics` exited with code 101
Error: Process completed with exit code 101.

PR checks / Lint

No logs available for this step.

PR checks / Python tests / test-rust-single-node-integration (3.9, --ignore-glob 'chromadb/test/property/*' --ignore-glob 'c...

No logs available for this step.

PR checks / Rust tests / Integration test ci_k8s_integration 2

No logs available for this step.

PR checks / Python tests / test-rust-bindings (3.9, --ignore-glob 'chromadb/test/property/*' --ignore-glob 'chromadb/test/st...

Step "Test" from job "Python tests / test-rust-bindings (3.9, --ignore-glob 'chromadb/test/property/*' --ignore-glob 'chromadb/test/st..." is failing. The last 20 log lines are:

[...]
  /opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/httpx/_config.py:51: DeprecationWarning: `verify=<str>` is deprecated. Use `verify=ssl.create_default_context(cafile=...)` or `verify=ssl.create_default_context(capath=...)` instead.
    warnings.warn(message, DeprecationWarning)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================= slowest 10 durations =============================
25.03s call     chromadb/test/api/test_limit_offset.py::test_get_limit_offset[rust_sqlite_persistent]
15.37s call     chromadb/test/api/test_limit_offset.py::test_get_limit_offset[rust_sqlite_ephemeral]
15.33s call     chromadb/test/test_multithreaded.py::test_interleaved_add_query[rust_sqlite_ephemeral]
12.18s call     chromadb/test/test_multithreaded.py::test_interleaved_add_query[rust_sqlite_persistent]
12.02s call     chromadb/test/ef/test_default_ef.py::test_invalid_sha256
11.94s call     chromadb/test/test_multithreaded.py::test_multithreaded_add[rust_sqlite_ephemeral]
11.32s call     chromadb/test/test_cli.py::test_vacuum_errors_if_locked[rust_sqlite_persistent]
9.49s call     chromadb/test/test_multithreaded.py::test_multithreaded_add[rust_sqlite_persistent]
7.12s call     chromadb/test/api/test_list_databases.py::test_list_databases_with_limit_offset[rust_sqlite_persistent]
6.07s call     chromadb/test/ef/test_default_ef.py::test_unavailable_provider_multiple
=========================== short test summary info ============================
FAILED chromadb/test/test_api.py::test_collection_upsert_with_invalid_collection_throws[rust_sqlite_ephemeral] - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value
FAILED chromadb/test/test_api.py::test_collection_upsert_with_invalid_collection_throws[rust_sqlite_persistent] - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value
= 2 failed, 368 passed, 26 skipped, 1 xfailed, 656 warnings in 198.63s (0:03:18) =
Error: Process completed with exit code 1.

PR checks / all-required-pr-checks-passed

Step "Decide whether the needed jobs succeeded or failed" from job "all-required-pr-checks-passed" is failing. The last 20 log lines are:

[...]
}
EOM
)"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  GITHUB_REPO_NAME: chroma-core/chroma
  PYTHONPATH: /home/runner/_work/_actions/re-actors/alls-green/release/v1/src
# ❌ Some of the required to succeed jobs failed 😢😢😢

📝 Job statuses:
📝 python-tests → ❌ failure [required to succeed or be skipped]
📝 python-vulnerability-scan → ✓ success [required to succeed or be skipped]
📝 javascript-client-tests → ✓ success [required to succeed or be skipped]
📝 rust-tests → ❌ failure [required to succeed or be skipped]
📝 go-tests → ✓ success [required to succeed or be skipped]
📝 lint → ❌ failure [required to succeed]
📝 check-helm-version-bump → ⬜ skipped [required to succeed or be skipped]
📝 delete-helm-comment → ✓ success [required to succeed or be skipped]
Error: Process completed with exit code 1.

1 job failed running on non-Blacksmith runners.

---

Summary: 1 successful workflow, 1 failed workflow

• ✅ Check PR Title (1 job succeeded)
• ❌ PR checks (43 jobs succeeded, 8 jobs failed)

Last updated: 2025-07-09 19:03:28 UTC