Skip to content

[ENH] add query config on collection configuration #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Jun 20, 2025

Description of changes

This PR adds a new function embed_query on the base embeddingfunction type to allow embedding functions to define a secondary path to embed documents for query path. by default this will invoke the call method.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

jairad26 commented Jun 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26 jairad26 force-pushed the jai/query-coll-config branch 5 times, most recently from 2d66a17 to 69696fd Compare June 21, 2025 00:37
@jairad26 jairad26 force-pushed the jai/query-coll-config branch 3 times, most recently from a339c38 to 34225f8 Compare June 24, 2025 17:34
@jairad26 jairad26 force-pushed the jai/query-coll-config branch 6 times, most recently from 7eac9c8 to bd49feb Compare June 30, 2025 23:53
@jairad26 jairad26 force-pushed the jai/query-coll-config branch 2 times, most recently from 36a2766 to 0a6cc75 Compare July 8, 2025 18:34
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 0a6cc75 to a219bb3 Compare July 11, 2025 21:54
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from a219bb3 to e67eb4f Compare July 25, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant