simplify aix_chsec

[foobarbam]

Description

• Refactor aix_chsec resource to utilize AIX tooling for inspection of current values.
• Fix issue aix_chsec bug in cases where resource's name doesn't match the proper file_name.
  previous code used ::File.exist?(new_resource.name) instead of ::File.exist?(file_name)
• make attributes and stanza properties required for aix_chsec
• minor version bump to 1.2.1

Issues Resolved

see above, non-documented but experienced in local testing

Check List

• [ rake passes ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• [ n/a ] New functionality includes testing.
• [ n/a ] New functionality has been documented in the README if applicable
• [ X ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[ghost]

Good work \o/. Thank you :).

[tas50]

Is there a reason this was commented out?

[foobarbam]

In my testing it would cause Ruby to complain about useless hash redefinitions, which is correct, no? You cannot have the same hash key twice, the last defined will be the only one used. (note that the 'xpm' key is defined twice in there).

[foobarbam]

I still had a terminal with the offending output, here's a snippet of what I was seeing (in rspec):

tests::remote_chef_gem
  aix 6.1
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
Please report a bug if this causes problems.
    cleanup dummies
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    downloads and installs dummy gem
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    downloads and upgrades dummy gem
  aix 7.1
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    cleanup dummies
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    downloads and installs dummy gem
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    downloads and upgrades dummy gem
  redhat 7.0
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    cleanup dummies
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    downloads and installs dummy gem
/tmp/chefspec20161104-26989-lxarfile_cache_path/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358
    downloads and upgrades dummy gem

[ghost]

Same behaviour xpm key is duplicated
One must be removed (not commented)

Installing Cookbook Gems:
Compiling Cookbooks...
/var/cache/chef/cookbooks/aix/libraries/helpers.rb:357: warning: key "xpm" is duplicated and overwritten on line 358

[foobarbam]

done

[foobarbam]

Duplicate keys removed as requested Is there something else wrong here @chmod666org or @tas50 . I'll fix whatever is necessary, my fork has been working well on my AIX systems. Is anything wrong

[foobarbam]

So I'm a jerk and totally blew off fixing this.

I've rebased on current master and eliminated the duplicate key.

Please review and comment.

Thanks!

[foobarbam]

@tas50,

Will this suffice or would you prefer we leave the duplicate key in place?

[tas50]

@foobarbam Sorry for the late response here, but if you want to rebase this I'll get it merged in.