aix_chsec simplification

[srctarget]

Description

This is bringing forward some of the changes (Descriptions included below) from #59 :
Simplify aix_chsec
make attributes and stanza properties required for aix_chsec
Version bump to 2.2.1
Would close PR #59 with this PR

Issues Resolved

see above, non-documented but experienced in local testing

Check List

• [rspec passes] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• [n/a] New functionality includes testing.
• [n/a] New functionality has been documented in the README if applicable
• All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[iennae]

please don't update the metadata version information.

[iennae]

@msgarbossa could you take a look at this PR and give your feedback if you have time? Thanks so much.

[iennae]

converting properties to required would be a major change as it would break folks using this resource previously who didn't have it included in their wrapper

[iennae]

nr isn't a great name to use as it obscures what's happening throughout the resource.

[iennae]

Changes as specified in comments please.

[srctarget]

I reverted the requirements on the properties and the version in the metadata.rb file. Also re-factored nr to be new_res.

[msgarbossa]

This breaks when I test the chsec resource in a recipe with the following for setting default password policy:

aix_chsec '/etc/security/user' do
  attributes(minlen: '15', minalpha: '2')
  stanza 'default'
  action :update
end

I get the following error:

  * aix_chsec[/etc/security/user] action update

    ================================================================================
    Error executing action `update` on resource 'aix_chsec[/etc/security/user]'
    ================================================================================

    NoMethodError
    -------------
    undefined method `attributes' for nil:NilClass

    Cookbook Trace:
    ---------------
    /var/chef/cache/cookbooks/aix/resources/chsec.rb:45:in `changed_attributes'
    /var/chef/cache/cookbooks/aix/resources/chsec.rb:109:in `block in class_from_file'

I believe the issue is with lines 45 and 46. new_resource and current_resource do not seem to be evaluating inside a def.

new_attributes     = @new_resource.attributes
current_attributes = @current_resource.attributes

[tas50]

@srctarget Thanks for pulling this together, but there's still a merge conflict with master. If you want to get that cleared up I can merge this in.

[srctarget]

Going to close this. Thank you.