-
Notifications
You must be signed in to change notification settings - Fork 191
ENT-10961, CFE-1840: Files promise can now modify immutable bit in file system attributes #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
larsewi
wants to merge
27
commits into
cfengine:master
Choose a base branch
from
larsewi:override-immutable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
bdd1918
to
69b1f52
Compare
06b3676
to
578286c
Compare
MMM, the transformer attribute comes to mind.
Looking at the files promise docs I imagine that
And the And
I added them to the description. |
Ticket: ENT-10961 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added syntax for `body fsattrs` with a boolean constraint `immutable`. It currently does nothing, but this will change in following commits. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-10961, CFE-1840 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: CFE-1840, ENT-10961 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The content attribute of the files promise can now override the immutable bit. Ticket: ENT-10961, CFE-1840 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the content attribute of the files promise can override the immutable bit. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
578286c
to
443524c
Compare
Added acceptance test to test that the copy_from attribute of the files promise can override the immutable bit of the destination file. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This way we don't have to explicitly pass it to a gazillion functions. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The copy_from attribute of the files promise can now override the immutable bit. Ticket: ENT-10961, CFE-1840 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the delete attribute of the files promise can override the immutable bit of the destination file. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The delete attribute of the files promise can now override the immutable bit. Ticket: ENT-10961, CFE-1840 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the edit_line attribute of the files promise can override the immutable bit of the destination file. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The edit_line and edit_xml attributes of the files promise can now override the immutable bit. Ticket: ENT-10961, CFE-1840 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the edit_xml attribute of the files promise can override the immutable bit of the destination file. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the perms attribute of the files promise can override the immutable bit of the destination file. For some reason it just works. I don't know why? Maybe it was indirectly fixed by previous commits?. IDK. But hey! It's Friday at 3:24 pm, so I will not ask any further questions. Instead, I'll add a changelog string in this commit and pretend that I intentionally fixed it. Ticket: ENT-10961, CFE-1840 Changelog: The perms attribute of the files promise can now override the immutable bit. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the touch attribute of the files promise can override the immutable bit of the destination file. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The touch attribute of the files promise can now override the immutable bit. Ticket: ENT-10961, CFE-1840 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the edit_template attribute (with mustache) of the files promise can override the immutable bit of the destination file. It just works. No need to edit the code further. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
443524c
to
6b70a44
Compare
Added acceptance test to test that the acl attribute of the files promise can override the immutable bit of the destination file. I'm getting errors stating that acl_get_file is not supported. Maybe something with WSL? Will retry when I'm back in office. ``` error: No Access ACL for '/tmp/immutable_10.txt' could be read. (acl_get_file: Operation not supported) ``` Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added acceptance test to test that the trasformer attribute of the files promise can override the immutable bit of the destination file. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
255054a
to
5628894
Compare
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The transformer attribute of the files promise can now override the immutable bit. Ticket: ENT-10961, CFE-1840 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
content
attributecopy_from
attributedelete
attributeedit_line
attributeedit_xml
attributeperms
attributetouch
attributeedit_template
attributeacl
attributetransformer
attributerename
attributeIs there any other ones that I've missed?