Skip to content

chore: Update text on verified domain tooltip to account for verified publisher #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+4 −5
Merged

chore: Update text on verified domain tooltip to account for verified publisher #5426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions templates/store/snap-details/_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,9 @@ <h2 class="p-modal__title" id="modal-title"><i class="p-icon--warning" style="wi
(Ownership verified)
<span class="p-tooltip--btm-right" aria-describedby="verified-explanation">
<i class="p-icon--information"></i>
<span class="p-tooltip__message" role="tooltip" id="verified-explanation">The publisher has verified that they own this domain.
It does not guarantee the Snap is an official upload from the
upstream project.</span>
</span>
<span class="p-tooltip__message" role="tooltip" id="verified-explanation">The publisher has verified that they own this domain{%- if developer_validation != VERIFIED_PUBLISHER -%}.
It does not guarantee the Snap is an official upload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With just this sentence being the difference, would it work to just wrap just this sentence in "if publisher is not verified" (instead of whole tooltip being difference inside if/else statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartaz I did try that, but with the text inside a tooltip being pre it messed up the spacing and indentation and looked broken

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, true.

I guess you could try doing {%- if … -%}…{%- endif -%} as dashes prevent Jinja from rendering empty lines in place of its commands, but it may still we fragile in pre.

from the upstream project.{%- endif -%}</span>
</template>

<script>
Expand Down Expand Up @@ -238,4 +237,4 @@ <h5 class="p-muted-heading">Report a Snap Store violation</h5>

{% include "store/snap-details/_report_snap_modal.html" %}
<hr>
{% endif %}
{% endif %}