-
Notifications
You must be signed in to change notification settings - Fork 116
chore: Update text on verified domain tooltip to account for verified publisher #5426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update text on verified domain tooltip to account for verified publisher #5426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the tooltip text for verified domain indicators to differentiate between verified domains and verified publishers. When a publisher is verified (not just their domain), a simpler message is shown without the upstream project disclaimer.
Key changes:
- Adds conditional rendering based on
developer_validation
status - Shows a simplified tooltip message for verified publishers
- Retains the more detailed disclaimer for domain-only verification
a7627a4
to
30019b7
Compare
<span class="p-tooltip__message" role="tooltip" id="verified-explanation">The publisher has verified that they own this domain</span> | ||
{% else %} | ||
<span class="p-tooltip__message" role="tooltip" id="verified-explanation">The publisher has verified that they own this domain. | ||
It does not guarantee the Snap is an official upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With just this sentence being the difference, would it work to just wrap just this sentence in "if publisher is not verified" (instead of whole tooltip being difference inside if/else statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartaz I did try that, but with the text inside a tooltip being pre
it messed up the spacing and indentation and looked broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, true.
I guess you could try doing {%- if … -%}…{%- endif -%}
as dashes prevent Jinja from rendering empty lines in place of its commands, but it may still we fragile in pre
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with an option to try if jinja still messes up formatting if {%- … -%}
are used.
30019b7
to
fa8d87e
Compare
Done
Amends the text for verified domains so verified publishers don't show the disclaimer which non-verified publishers have.
How to QA
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-30124