Skip to content

[daemon] fix unchecked iterator access in async start mounts #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

[daemon] fix unchecked iterator access in async start mounts #4006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/daemon/daemon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3425,8 +3425,15 @@
fmt::memory_buffer errors;
try
{
auto it = operative_instances.find(name);
auto vm = it->second;
const auto& it = operative_instances.find(name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const auto& and const auto should not make a difference here since the find function returns value.

if (operative_instances.end() == it)
{
fmt::format_to(std::back_inserter(errors),

Check warning on line 3431 in src/daemon/daemon.cpp

View check run for this annotation

Codecov / codecov/patch

src/daemon/daemon.cpp#L3431 

Added line #L3431 was not covered by tests
"Error starting mounts for VM `{}`, the VM is not in a operative state!",
name);
return fmt::to_string(errors);

Check warning on line 3434 in src/daemon/daemon.cpp

View check run for this annotation

Codecov / codecov/patch

src/daemon/daemon.cpp#L3434 

Added line #L3434 was not covered by tests
}
const auto vm = it->second;
vm->wait_until_ssh_up(timeout);

if (std::is_same<Reply, LaunchReply>::value)
Expand Down
Loading