Skip to content

36-change-rem-based-tokens-to-fixed-pixel #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

36-change-rem-based-tokens-to-fixed-pixel #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb7b76
updated px
bubulux Mar 27, 2025
006bd02
tests pass
bubulux Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions src/components/layout/Flex/tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ describe("Flex", () => {
expect(FlexElement).toHaveStyle("flex-shrink: 1");
expect(FlexElement).toHaveStyle("flex-wrap: nowrap");
expect(FlexElement).toHaveStyle("flex-basis: auto");
expect(FlexElement).toHaveStyle("gap: 0rem");
expect(FlexElement).toHaveStyle("margin: 0rem");
expect(FlexElement).toHaveStyle("padding: 0rem");
expect(FlexElement).toHaveStyle("gap: 0px");
expect(FlexElement).toHaveStyle("margin: 0px");
expect(FlexElement).toHaveStyle("padding: 0px");
expect(FlexElement).toHaveStyle("height: auto");
expect(FlexElement).toHaveStyle("width: auto");
expect(FlexElement).toHaveStyle("position: static");
Expand Down Expand Up @@ -180,57 +180,57 @@ describe("Flex", () => {
it("should render with gap None", () => {
render(<Flex gap="None">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0rem");
expect(FlexElement).toHaveStyle("gap: 0px");
});
it("should render with gap XXS", () => {
render(<Flex gap="XXS">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0.125rem");
expect(FlexElement).toHaveStyle("gap: 2px");
});
it("should render with gap XS", () => {
render(<Flex gap="XS">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0.25rem");
expect(FlexElement).toHaveStyle("gap: 4px");
});
it("should render with gap SNudge", () => {
render(<Flex gap="SNudge">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0.375rem");
expect(FlexElement).toHaveStyle("gap: 6px");
});
it("should render with gap S", () => {
render(<Flex gap="S">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0.5rem");
expect(FlexElement).toHaveStyle("gap: 8px");
});
it("should render with gap MNudge", () => {
render(<Flex gap="MNudge">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0.625rem");
expect(FlexElement).toHaveStyle("gap: 10px");
});
it("should render with gap M", () => {
render(<Flex gap="M">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 0.75rem");
expect(FlexElement).toHaveStyle("gap: 12px");
});
it("should render with gap L", () => {
render(<Flex gap="L">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 1rem");
expect(FlexElement).toHaveStyle("gap: 16px");
});
it("should render with gap XL", () => {
render(<Flex gap="XL">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 1.25rem");
expect(FlexElement).toHaveStyle("gap: 20px");
});
it("should render with gap XXL", () => {
render(<Flex gap="XXL">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 1.5rem");
expect(FlexElement).toHaveStyle("gap: 24px");
});
it("should render with gap XXXL", () => {
render(<Flex gap="XXXL">FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("gap: 2rem");
expect(FlexElement).toHaveStyle("gap: 32px");
});
});
describe("for grow", () => {
Expand Down Expand Up @@ -298,44 +298,44 @@ describe("Flex", () => {
it("should render with margin None", () => {
render(<Flex margin={["None"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("margin: 0rem");
expect(FlexElement).toHaveStyle("margin: 0px");
});
it("should render with margin XS, L", () => {
render(<Flex margin={["XS", "L"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("margin: 0.25rem 1rem 0.25rem 1rem");
expect(FlexElement).toHaveStyle("margin: 4px 16px 4px 16px");
});
it("should render with margin XS, L, XL", () => {
render(<Flex margin={["XS", "L", "XL"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("margin: 0.25rem 1rem 1.25rem 1rem");
expect(FlexElement).toHaveStyle("margin: 4px 16px 20px 16px");
});
it("should render with margin XS, L, XL, XXL", () => {
render(<Flex margin={["XS", "L", "XL", "XXL"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("margin: 0.25rem 1rem 1.25rem 1.5rem");
expect(FlexElement).toHaveStyle("margin: 4px 16px 20px 24px");
});
});
describe("for padding", () => {
it("should render with padding None", () => {
render(<Flex padding={["None"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("padding: 0rem");
expect(FlexElement).toHaveStyle("padding: 0px");
});
it("should render with padding XS, L", () => {
render(<Flex padding={["XS", "L"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("padding: 0.25rem 1rem 0.25rem 1rem");
expect(FlexElement).toHaveStyle("padding: 4px 16px 4px 16px");
});
it("should render with padding XS, L, XL", () => {
render(<Flex padding={["XS", "L", "XL"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("padding: 0.25rem 1rem 1.25rem 1rem");
expect(FlexElement).toHaveStyle("padding: 4px 16px 20px 16px");
});
it("should render with padding XS, L, XL, XXL", () => {
render(<Flex padding={["XS", "L", "XL", "XXL"]}>FlexChild</Flex>);
const FlexElement = screen.getByText("FlexChild");
expect(FlexElement).toHaveStyle("padding: 0.25rem 1rem 1.25rem 1.5rem");
expect(FlexElement).toHaveStyle("padding: 4px 16px 20px 24px");
});
});
describe("for shHeight", () => {
Expand Down
Loading