36-change-rem-based-tokens-to-fixed-pixel #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bubulux
commented
Mar 27, 2025
bubulux
commented
- for dimensions
- for spacing
There was a problem hiding this comment.
Pull Request Overview
This PR updates theme tokens for spacing and dimensions by switching from rem-based units to fixed pixel values.
- Spacing tokens are now expressed in pixels rather than rem units.
- Dimension tokens have been similarly converted from rem values to corresponding pixel values.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/theme/tokens/spacing.ts | Updates spacing tokens from rem values to fixed pixels. |
| src/theme/tokens/dimensions.ts | Updates dimension tokens from rem values to fixed pixels. |
src/theme/tokens/spacing.ts
Outdated
| @@ -2,47 +2,47 @@ enum EThemeSpacing { | |||
| /** | |||
| * 0px | |||
| */ | |||
| None = "0rem", | |||
| None = "0", | |||
There was a problem hiding this comment.
The 'None' token value is changed to '0' without a unit while other tokens use 'px'. Although '0' is valid in CSS, for consistency consider updating it to '0px'.
Suggested change
| None = "0", | |
| None = "0px", |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.