CORE-308 Use okhttp rite #1570
Merged
CORE-308 Use okhttp rite #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
requested review from
kevinmarete and
marctalbott
and removed request for
a team
dvoet
commented
Feb 25, 2025
|
|
||
| private def newApiClient(user: WithAccessToken) = { | ||
| val apiClient = new ApiClient() | ||
| val apiClient = new ApiClient(httpClient) |
There was a problem hiding this comment.
This is the important change. httpClient is reused across all sam calls using the client library
dvoet
commented
Feb 25, 2025
Comment on lines
+62
to
+63
| dispatcher.setMaxRequests(1000) | ||
| dispatcher.setMaxRequestsPerHost(100) |
There was a problem hiding this comment.
I am just guessing here. I will circle back to make these configurable if this ends up helping
dvoet
commented
Feb 25, 2025
| implicit val executionContext: ExecutionContext | ||
| implicit val materializer: Materializer | ||
|
|
||
| val samDao: SamDAO |
There was a problem hiding this comment.
changes in this file are related to moving the getUserStatusInfo call to samDAO
dvoet
commented
Feb 25, 2025
|
|
||
| implicit override val executionContext: ExecutionContext = scala.concurrent.ExecutionContext.Implicits.global | ||
|
|
||
| val samDao: SamDAO = mock[SamDAO](RETURNS_SMART_NULLS) |
There was a problem hiding this comment.
can use mockito now instead of a mock http server
marctalbott
approved these changes
Feb 25, 2025
kevinmarete
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/CORE-308
An observation from the logs is that for orch, the connect timeouts only occur using Sam's client library. Orch only uses sam client library for 2 calls,
getUserStatusInfoandbulkMembershipUpdateV2. All other calls use a hand rolled client using akka http. Granted,getUserStatusInfois called on every api call so the prevalence of the error might be biased towards that call.The crux of this change is to use a shared instance of the okhttp client configured for large bandwidth to sam. As it was, each new
ApiClientwas creating a bunch of resources for single use that were meant to be reused. This will hopefully lead to fewer connection attempts and fewer timeouts.An ancillary change is to move a call to sam into the SamDAO (I don't know why it wasn't there to start... probably plumbing issues).
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: