CORE-308: reuse okhttp client for Leo DAO #3235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
approved these changes
Mar 25, 2025
davidangb
requested review from
a team,
calypsomatic and
samanehsan
and removed request for
a team and
samanehsan
calypsomatic
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CORE-308
Reuse an underlying
okhttpclient within the Leo DAO.This PR does NOT do any of the fancier config such as setting max requests or max requests per host or request timeout on the DAO. We can set those later if we find we need them.
See the changes to the Sam DAO in broadinstitute/firecloud-orchestration#1570 as an example.