Skip to content

Add: Tests on local runners with shared USB resources #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add: Tests on local runners with shared USB resources #63

merged 1 commit into from
Oct 15, 2024

Conversation

RaulTrombin
Copy link
Member

@RaulTrombin RaulTrombin commented Oct 8, 2024 •
edited
Loading

image

@RaulTrombin RaulTrombin force-pushed the test_fixtures branch 15 times, most recently from 7f13f61 to 3ae5166 Compare October 10, 2024 21:07
@RaulTrombin RaulTrombin changed the title test Add: Tests on local runners with shared USB resources Oct 10, 2024
@RaulTrombin RaulTrombin marked this pull request as ready for review October 10, 2024 21:23
@RaulTrombin RaulTrombin mentioned this pull request Oct 10, 2024
Merged
1 task
@RaulTrombin RaulTrombin mentioned this pull request Oct 10, 2024
Merged
1 task
joaoantoniocardoso
joaoantoniocardoso approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Is there a way to add a cache for that build? (for the future, as it is quite fast now)

joaoantoniocardoso
joaoantoniocardoso reviewed Oct 12, 2024
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually.... Can we not use those deprecated gh actions (or have an updated version)? There are a bunch of warnings.

@RaulTrombin RaulTrombin force-pushed the test_fixtures branch 4 times, most recently from e913aad to dbbf33e Compare October 15, 2024 14:27
@RaulTrombin RaulTrombin merged commit 0f3a352 into bluerobotics:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickelectric patrickelectric Awaiting requested review from patrickelectric

1 more reviewer

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RaulTrombin @joaoantoniocardoso