Skip to content

fix(anr): handle missing fields in frame matcher #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented May 15, 2025

perf improvements

  • added early exits for method and file parsing by excluding separator characters ('.' and ':')
  • skip string trim in favor of what should be a fairly quick and performant match on exactly whitespace + 'at'

fixes

  • handle lines where one or more of the stack fields (method, file, line number) are missing + additional tests

added extra docs for the regex itself for future travelers

@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch 2 times, most recently from 93da97b to b2af2b0 Compare May 15, 2025 18:06
Copy link
Contributor

@FranAguilera FranAguilera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, for completeness could you add a timeline session link in PR description with ANR stacktrace?

@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch 2 times, most recently from 7103ec6 to 5d4261f Compare May 20, 2025 09:52
@bitdriftlabs bitdriftlabs deleted a comment from github-actions bot May 20, 2025
@bitdriftlabs bitdriftlabs deleted a comment from github-actions bot May 20, 2025
Copy link

📦 APK Size Report

Metric Size (KB)
Baseline 3631
Current 3635
Difference 4

❌ APK size increased by 4 KB.

@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch from 5d4261f to b0df4d9 Compare May 23, 2025 14:31
@kattrali kattrali changed the base branch from main to franjam/expose-built-in May 23, 2025 14:31
@FranAguilera FranAguilera force-pushed the franjam/expose-built-in branch from 88eb99c to b26ab5f Compare May 23, 2025 14:33
@kattrali kattrali changed the title perf(anr): make anr stack matching more specific fix(anr): handle missing fields in frame matcher May 23, 2025
@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch 3 times, most recently from d24e080 to c3fd74d Compare May 23, 2025 14:45
@FranAguilera FranAguilera force-pushed the franjam/expose-built-in branch 2 times, most recently from a315d50 to 59bec25 Compare May 23, 2025 15:01
@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch from c3fd74d to e6046c4 Compare May 23, 2025 15:02
Copy link

📦 APK Size Report

Metric Size (KB)
Baseline 3570
Current 3570
Difference 0

✅ APK size unchanged.

@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch from e6046c4 to da0d62d Compare May 23, 2025 15:06
Copy link

📦 APK Size Report

Metric Size (KB)
Baseline 3570
Current 3574
Difference 4

❌ APK size increased by 4 KB.

@FranAguilera FranAguilera force-pushed the franjam/expose-built-in branch 3 times, most recently from 077e9f0 to 2656edf Compare May 23, 2025 16:28
Base automatically changed from franjam/expose-built-in to main May 23, 2025 16:52
kattrali added 2 commits May 23, 2025 19:04
added early exits for method and file parsing by excluding
separator characters ('.' and ':')

skip string trim in favor of what should be a fairly quick and
performant match on exactly whitespace + 'at'

extra docs for the regex itself for future travelers
@kattrali kattrali force-pushed the dfuller/small-anr-perf-boost branch from da0d62d to 14dea02 Compare May 23, 2025 18:04
Copy link

📦 APK Size Report

Metric Size (KB)
Baseline 3570
Current 3574
Difference 4

❌ APK size increased by 4 KB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants