-
Notifications
You must be signed in to change notification settings - Fork 6
fix(anr): handle missing fields in frame matcher #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kattrali
wants to merge
2
commits into
main
Choose a base branch
from
dfuller/small-anr-perf-boost
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93da97b
to
b2af2b0
Compare
FranAguilera
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, for completeness could you add a timeline session link in PR description with ANR stacktrace?
7103ec6
to
5d4261f
Compare
📦 APK Size Report
|
5d4261f
to
b0df4d9
Compare
88eb99c
to
b26ab5f
Compare
d24e080
to
c3fd74d
Compare
a315d50
to
59bec25
Compare
c3fd74d
to
e6046c4
Compare
📦 APK Size Report
|
e6046c4
to
da0d62d
Compare
📦 APK Size Report
|
077e9f0
to
2656edf
Compare
added early exits for method and file parsing by excluding separator characters ('.' and ':') skip string trim in favor of what should be a fairly quick and performant match on exactly whitespace + 'at' extra docs for the regex itself for future travelers
da0d62d
to
14dea02
Compare
📦 APK Size Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf improvements
fixes
added extra docs for the regex itself for future travelers