fix(anr): handle source lines without method, file, or line

Author: kattrali

platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/reports/processor/AppExitAnrTraceProcessor.kt

@@ -28,12 +28,12 @@ internal object AppExitAnrTraceProcessor {
 
     // matcher for lines like `    at some.pkg.ClassName.doSomething(ClassName.kt:732)`
     // * class  - fully-qualified class
-    // * method - method within class
+    // * method - method, starting with a match for Character.isJavaIdentifierStart() (java spec 3.8)
     // * file   - class source file
     // * line   - line number
     private val ANR_STACK_TRACE_REGEX =
         Regex(
-            "^\\s+at\\s+(?<class>.+)\\.(?<method>[^.]+)\\((?<file>[^:]+):(?<line>\\d+)\\)\$",
+            "^\\s+at\\s+(?<class>[.\\w]+?)(?:\\.(?<method>[a-z_\$][\\w\$]*))?(?:\\((?<file>[^:]+)(?::(?<line>\\d+))?\\))?\$",
         )
     private val mainStackTraceFrames = mutableListOf<Int>()
     private var isProcessingMainThreadTrace = false
@@ -96,20 +96,23 @@ internal object AppExitAnrTraceProcessor {
             if (!isProcessingMainThreadTrace) {
                 return
             }
-            val path = builder.createString(fileName)
             val sourceFile =
-                SourceFile.createSourceFile(
-                    builder,
-                    path,
-                    lineNumber.toLongOrNull() ?: 0,
-                    0,
-                )
+                if (fileName.isEmpty()) {
+                    0
+                } else {
+                    SourceFile.createSourceFile(
+                        builder,
+                        builder.createString(fileName),
+                        lineNumber.toLongOrNull() ?: 0,
+                        0,
+                    )
+                }
             val frame =
                 Frame.createFrame(
                     builder,
                     FrameType.JVM,
                     builder.createString(className),
-                    builder.createString(symbolName),
+                    if (symbolName.isEmpty()) 0 else builder.createString(symbolName),
                     sourceFile,
                     0,
                     0u,

platform/jvm/capture/src/test/kotlin/io/bitdrift/capture/FatalIssueReporterProcessorTest.kt

@@ -279,12 +279,57 @@ class FatalIssueReporterProcessorTest {
         assertThat(report.errors(0)).isNotNull
         report.errors(0)?.let { error ->
             assertThat(error.name).isEqualTo(expectedMessage)
-            val frame = error.stackTrace(0)
-            assertThat(frame).isNotNull
-            assertThat(frame!!.sourceFile!!.line).isEqualTo(106)
-            assertThat(frame.sourceFile!!.path).isEqualTo("FatalIssueGenerator.kt")
-            assertThat(frame.symbolName).isEqualTo("startProcessing")
-            assertThat(frame.className).isEqualTo("io.bitdrift.capture.FatalIssueGenerator")
+            val firstFrame = error.stackTrace(0)
+            assertThat(firstFrame).isNotNull
+            firstFrame?.let { frame ->
+                assertThat(frame.sourceFile!!.line).isEqualTo(106)
+                assertThat(frame.sourceFile!!.path).isEqualTo("FatalIssueGenerator.kt")
+                assertThat(frame.symbolName).isEqualTo("startProcessing")
+                assertThat(frame.className).isEqualTo("io.bitdrift.capture.FatalIssueGenerator")
+            }
+
+            val secondFrame = error.stackTrace(1)
+            assertThat(secondFrame).isNotNull
+            secondFrame?.let { frame ->
+                assertThat(frame.sourceFile!!.line).isEqualTo(35)
+                assertThat(frame.sourceFile!!.path).isEqualTo("FatalIssueGenerator.kt")
+                assertThat(frame.symbolName).isEqualTo("forceDeadlockAnr\$")
+                assertThat(frame.className).isEqualTo("io.bitdrift.capture.FatalIssueGenerator")
+            }
+
+            val unavailableFrame = error.stackTrace(2)
+            assertThat(unavailableFrame).isNotNull
+            unavailableFrame?.let { frame ->
+                assertThat(frame.sourceFile!!.line).isEqualTo(0)
+                assertThat(frame.sourceFile!!.path).isEqualTo("unavailable")
+                assertThat(frame.symbolName).isNull()
+                assertThat(frame.className).isEqualTo("io.bitdrift.capture.FatalIssueGenerator")
+            }
+
+            val noMethodNoSourceFrame = error.stackTrace(3)
+            assertThat(noMethodNoSourceFrame).isNotNull
+            noMethodNoSourceFrame?.let { frame ->
+                assertThat(frame.sourceFile).isNull()
+                assertThat(frame.symbolName).isNull()
+                assertThat(frame.className).isEqualTo("io.bitdrift.capture.FatalIssueGenerator")
+            }
+
+            val unsourcedFrame = error.stackTrace(4)
+            assertThat(unsourcedFrame).isNotNull
+            unsourcedFrame?.let { frame ->
+                assertThat(frame.sourceFile).isNull()
+                assertThat(frame.symbolName).isEqualTo("callOnMainThread")
+                assertThat(frame.className).isEqualTo("io.bitdrift.capture.FatalIssueGenerator")
+            }
+
+            val nativeFrame = error.stackTrace(12)
+            assertThat(nativeFrame).isNotNull
+            nativeFrame?.let { frame ->
+                assertThat(frame.sourceFile!!.line).isEqualTo(0)
+                assertThat(frame.sourceFile!!.path).isEqualTo("Native method")
+                assertThat(frame.symbolName).isEqualTo("invoke")
+                assertThat(frame.className).isEqualTo("java.lang.reflect.Method")
+            }
         }
     }