Skip to content

feat: new Negative Controls implementation using strategies and manager #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

fix: correct error message for segSeries loading, remove more duplica…

745808b
Select commit
Loading
Failed to load commit list.
Closed

feat: new Negative Controls implementation using strategies and manager #74

fix: correct error message for segSeries loading, remove more duplica…
745808b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 11, 2024 in 1s

7.43% of diff hit (target 60.92%)

View this Pull Request on Codecov

7.43% of diff hit (target 60.92%)

Annotations

Check warning on line 228 in src/readii/negative_controls.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls.py#L227-L228 

Added lines #L227 - L228 were not covered by tests

Check warning on line 300 in src/readii/negative_controls.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls.py#L299-L300 

Added lines #L299 - L300 were not covered by tests

Check warning on line 357 in src/readii/negative_controls.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls.py#L356-L357 

Added lines #L356 - L357 were not covered by tests

Check warning on line 360 in src/readii/negative_controls.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls.py#L359-L360 

Added lines #L359 - L360 were not covered by tests

Check warning on line 6 in src/readii/negative_controls_refactor/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/__init__.py#L3-L6 

Added lines #L3 - L6 were not covered by tests

Check warning on line 8 in src/readii/negative_controls_refactor/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/__init__.py#L8 

Added line #L8 was not covered by tests

Check warning on line 3 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L1-L3 

Added lines #L1 - L3 were not covered by tests

Check warning on line 6 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L5-L6 

Added lines #L5 - L6 were not covered by tests

Check warning on line 9 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L9 

Added line #L9 was not covered by tests

Check warning on line 12 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L12 

Added line #L12 was not covered by tests

Check warning on line 16 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L15-L16 

Added lines #L15 - L16 were not covered by tests

Check warning on line 18 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L18 

Added line #L18 was not covered by tests

Check warning on line 21 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L20-L21 

Added lines #L20 - L21 were not covered by tests

Check warning on line 29 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L29 

Added line #L29 was not covered by tests

Check warning on line 33 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L32-L33 

Added lines #L32 - L33 were not covered by tests

Check warning on line 41 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L41 

Added line #L41 was not covered by tests

Check warning on line 44 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L43-L44 

Added lines #L43 - L44 were not covered by tests

Check warning on line 53 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L53 

Added line #L53 was not covered by tests

Check warning on line 56 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L55-L56 

Added lines #L55 - L56 were not covered by tests

Check warning on line 64 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L64 

Added line #L64 was not covered by tests

Check warning on line 66 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L66 

Added line #L66 was not covered by tests

Check warning on line 88 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L88 

Added line #L88 was not covered by tests

Check warning on line 93 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L90-L93 

Added lines #L90 - L93 were not covered by tests

Check warning on line 98 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L96-L98 

Added lines #L96 - L98 were not covered by tests

Check warning on line 101 in src/readii/negative_controls_refactor/abstract_classes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/readii/negative_controls_refactor/abstract_classes.py#L101 

Added line #L101 was not covered by tests
View more details on Codecov