Skip to content

feat: new Negative Controls implementation using strategies and manager #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

fix: correct error message for segSeries loading, remove more duplica…

745808b
Select commit
Loading
Failed to load commit list.
Closed

feat: new Negative Controls implementation using strategies and manager #74

fix: correct error message for segSeries loading, remove more duplica…
745808b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 11, 2024 in 1s

48.96% (-11.97%) compared to 3bcaa28

View this Pull Request on Codecov

48.96% (-11.97%) compared to 3bcaa28

Details

Codecov Report

Attention: Patch coverage is 7.43243% with 137 lines in your changes missing coverage. Please review.

Project coverage is 48.96%. Comparing base (3bcaa28) to head (745808b).

Files with missing lines Patch % Lines
...dii/negative_controls_refactor/abstract_classes.py 0.00% 47 Missing ⚠️
...ii/negative_controls_refactor/negative_controls.py 0.00% 33 Missing ⚠️
src/readii/negative_controls_refactor/regions.py 0.00% 23 Missing ⚠️
src/readii/negative_controls_refactor/manager.py 0.00% 21 Missing ⚠️
src/readii/negative_controls.py 55.55% 8 Missing ⚠️
src/readii/negative_controls_refactor/__init__.py 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #74       +/-   ##
===========================================
- Coverage   60.92%   48.96%   -11.97%     
===========================================
  Files          10       15        +5     
  Lines         540      674      +134     
===========================================
+ Hits          329      330        +1     
- Misses        211      344      +133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov