-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Open
Labels
A-Cross-CuttingImpacts the entire engineImpacts the entire engineC-DependenciesA change to the crates that Bevy depends onA change to the crates that Bevy depends onC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyM-Needs-Migration-GuideA breaking change to Bevy's public API that needs to be noted in a migration guideA breaking change to Bevy's public API that needs to be noted in a migration guideS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Description
Bevy has reused the same conceptual names for multiple types across things within bevy. Ie Query is used by bevy_ecs and cosmic_text, Handle in Bevy_asset and bevy_log, etc
This creates confusion especially for autocomplete tooling like in vscode where the conflict leads to confusing errors that a normal person will not understand as syntactically they have done everything correctly.
Bevy should reserve the key conceptual ideas such as Query, Param, System, Handle, etc and any reuse should be name scoped, ex cosmic_text Query renamed to CosmicQuery etc
Checklist of conflicts:
- cosmic_text re-export: Remove re-exports of cosmic_text types #19516
- bevy_log re-export of Handle: TODO
- Entry: Rename bevy_ecs::world::Entry to ComponentEntry #19517
- bevy_assets::Entry: TODO
- bevy_scene::ron re-exports: TODO
- encase re-exports: TODO
-
ScalingMode
duplicate names
alice-i-cecile, benfrankel, notmd and stan4cb
Metadata
Metadata
Assignees
Labels
A-Cross-CuttingImpacts the entire engineImpacts the entire engineC-DependenciesA change to the crates that Bevy depends onA change to the crates that Bevy depends onC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyM-Needs-Migration-GuideA breaking change to Bevy's public API that needs to be noted in a migration guideA breaking change to Bevy's public API that needs to be noted in a migration guideS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon