Skip to content

Commit da59de9

Browse files
ickshonpemockersf
andauthored
Remove the With<Parent> query filter from bevy_ui::render::extract_uinode_borders (#9285)
# Objective Remove the `With<Parent>` query filter from the `parent_node_query` parameter of the `bevy_ui::render::extract_uinode_borders` function. This is a bug, the query is only used to retrieve the size of the current node's parent. We don't care if that parent node has a `Parent` or not. --------- Co-authored-by: François <mockersf@gmail.com>
1 parent fb19b81 commit da59de9

File tree

1 file changed

+2
-2
lines changed
  • crates/bevy_ui/src/render

1 file changed

+2
-2
lines changed

crates/bevy_ui/src/render/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ pub fn extract_uinode_borders(
276276
Without<ContentSize>,
277277
>,
278278
>,
279-
parent_node_query: Extract<Query<&Node, With<Parent>>>,
279+
node_query: Extract<Query<&Node>>,
280280
) {
281281
let image = bevy_render::texture::DEFAULT_IMAGE_HANDLE.typed();
282282

@@ -304,7 +304,7 @@ pub fn extract_uinode_borders(
304304
// Both vertical and horizontal percentage border values are calculated based on the width of the parent node
305305
// <https://developer.mozilla.org/en-US/docs/Web/CSS/border-width>
306306
let parent_width = parent
307-
.and_then(|parent| parent_node_query.get(parent.get()).ok())
307+
.and_then(|parent| node_query.get(parent.get()).ok())
308308
.map(|parent_node| parent_node.size().x)
309309
.unwrap_or(ui_logical_viewport_size.x);
310310
let left =

0 commit comments

Comments
 (0)