Fix end-of-animation index OOB (#6210)

thebluefish · thebluefish · commit c6e0da4bcb2b · 2022-10-17T16:42:34.000Z
# Objective Fixes #6204 ## Solution Added another branch to handle end-of-animation special case
diff --git a/crates/bevy_animation/src/lib.rs b/crates/bevy_animation/src/lib.rs
@@ -243,6 +243,7 @@ pub fn animation_player(
                             .keyframe_timestamps
                             .binary_search_by(|probe| probe.partial_cmp(&elapsed).unwrap())
                         {
+                            Ok(n) if n >= curve.keyframe_timestamps.len() - 1 => continue, // this curve is finished
                             Ok(i) => i,
                             Err(0) => continue, // this curve isn't started yet
                             Err(n) if n > curve.keyframe_timestamps.len() - 1 => continue, // this curve is finished

Original file line number	Diff line number	Diff line change
`@@ -243,6 +243,7 @@ pub fn animation_player(`
`243`	`243`	`.keyframe_timestamps`
`244`	`244`	`.binary_search_by(\|probe\| probe.partial_cmp(&elapsed).unwrap())`
`245`	`245`	`{`
	`246`	`+ Ok(n) if n >= curve.keyframe_timestamps.len() - 1 => continue, // this curve is finished`
`246`	`247`	`Ok(i) => i,`
`247`	`248`	`Err(0) => continue, // this curve isn't started yet`
`248`	`249`	`Err(n) if n > curve.keyframe_timestamps.len() - 1 => continue, // this curve is finished`