remove comments referring to type when untyped pointer is returned

Author: jakobhellermann

crates/bevy_ecs/src/storage/mod.rs

@@ -71,7 +71,7 @@ impl Storages {
                 let (components, table_row) =
                     fetch_table(archetypes, self, location, component_id)?;
 
-                // SAFETY: archetypes only store valid table_rows and the stored component type is T
+                // SAFETY: archetypes only store valid table_rows and caller ensure aliasing rules
                 Some((
                     components.get_data_unchecked(table_row),
                     TickCells {
@@ -130,7 +130,7 @@ impl Storages {
             StorageType::Table => {
                 let (components, table_row) =
                     fetch_table(archetypes, self, location, component_id)?;
-                // SAFETY: archetypes only store valid table_rows and the stored component type is T
+                // SAFETY: archetypes only store valid table_rows and caller ensure aliasing rules
                 Some(components.get_data_unchecked(table_row))
             }
             StorageType::SparseSet => fetch_sparse_set(self, component_id)?.get(entity),
@@ -182,7 +182,7 @@ impl Storages {
             StorageType::Table => {
                 let (components, table_row) =
                     fetch_table(archetypes, self, location, component_id)?;
-                // SAFETY: archetypes only store valid table_rows and the stored component type is T
+                // SAFETY: archetypes only store valid table_rows and caller ensure aliasing rules
                 Some(components.get_ticks_unchecked(table_row))
             }
             StorageType::SparseSet => fetch_sparse_set(self, component_id)?.get_ticks(entity),
@@ -201,7 +201,7 @@ impl Storages {
     /// - `location` must be within bounds of the given archetype and `entity` must exist inside the `archetype`
     /// - `component_id` must be valid
     /// - `components` must come from the same world as `self`
-    /// - The relevant table row **must be removed** by the caller once all components are taken
+    /// - The relevant table row **must be removed** by the caller once all components are taken, without dropping the value
     #[inline]
     pub(crate) unsafe fn take_component<'a>(
         &'a mut self,
@@ -219,7 +219,10 @@ impl Storages {
                 let table = &mut self.tables[location.table_id];
                 // SAFETY: archetypes will always point to valid columns
                 let components = table.get_column_mut(component_id).unwrap();
-                // SAFETY: archetypes only store valid table_rows and the stored component type is T
+                // SAFETY:
+                // - archetypes only store valid table_rows
+                // - index is in bounds as promised by caller
+                // - promote is safe because the caller promises to remove the table row without dropping it immediately afterwards
                 components
                     .get_data_unchecked_mut(location.table_row)
                     .promote()

crates/bevy_ecs/src/world/entity_ref.rs

@@ -439,7 +439,7 @@ impl<'w> EntityMut<'w> {
                 let component_id = bundle_components.next().unwrap();
                 // SAFETY:
                 // - entity location is valid
-                // - table row is removed below
+                // - table row is removed below, without dropping the contents
                 // - `components` comes from the same world as `storages`
                 storages.take_component(
                     components,