Skip to content

Conversation

@philiptaron
Copy link

This additional PR continues the work you started in NixOS#413663.

  • Switch to lib.extendMkDerivation
  • Convert all users of buildGraalvmNativeImage to use finalAttrs style
  • Simplify buildGraalvmNativeImage further after the users are converted

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@philiptaron
Copy link
Author

@bengsparks

@bengsparks
Copy link
Owner

bengsparks commented Jun 5, 2025

@philiptaron Thanks very much for your work 😄 I'd reviewed this PR yesterday evening, and my tooling indicated that nativeImageBuildArgs in the parameter attribute set does not get used, but I think that's just a tooling bug? Can we just double-check that?
I've built all the packages that are affected by this PR already, so everything else LGTM.

@philiptaron philiptaron force-pushed the pr-413663/buildGraalvmNativeImage branch from 3276ef6 to 9411ce5 Compare June 5, 2025 19:48
@philiptaron
Copy link
Author

philiptaron commented Jun 5, 2025

Yeah, it wasn't used, since I switched in the final commit to args.nativeImageBuildArgs to pull it out. Updated.

@bengsparks bengsparks changed the base branch from bGVM to bGVM2 June 10, 2025 01:51
@bengsparks bengsparks merged commit 0665ba8 into bengsparks:bGVM2 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants