-
-
Notifications
You must be signed in to change notification settings - Fork 17.1k
buildGraalvmNativeImage: switch to lib.extendMkDerivation #413663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to use lib.extendMkDerivation. I'm going to make a PR against your branch...
| openjdk_headless = jdk_headless; | ||
|
|
||
| graalvmPackages = recurseIntoAttrs (callPackage ../development/compilers/graalvm { }); | ||
| buildGraalvmNativeImage = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, yikes
|
Done: bengsparks#1 |
Co-authored-by: Philip Taron <philip.taron@gmail.com>
Also rewrite the update script to reflect that src is just a jar
|
#412768's eval breaks because
executable ? args.pnamefails due tobuildGraalvmNativeImagedefaultingmeta.mainProgramtoexecutable.The error message reads:
This is surprising, as every package that uses
buildGraalvmNativeImagesupplies thepnamefield, as it is just a wrapper aroundstdenv.mkDerivation.I suspect the combination of
lib.intersectAttrsincallPackage(With)atnixpkgs/lib/customisation.nix
Line 247 in 054144e
buildGraalvmNativeImage = (callPackage ../build-support/build-graalvm-native-image { }.override)is to blame, but I cannot be sure.Due to the change in the
buildGraalvmNativeImagefunction, I don't think it's possible to make this a 0-rebuild PR.I tested this PR by
versionCheckProgramtomainProgram#412768I have also applied
diffoscopeto all of the packages thatnixpkgs-review rev HEADprinted on my system, and all seem to have remained identical, but I'm not entirely confident, as it seems there are minimal changes in some .JAR files, but all files seem to be present.If anyone has recommendations for options to tweak in
diffoscope, let me know 😄Here is the body of the script
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.