enable gRPC keepalive by default #27473
Open
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Remote-Exec
meisterT
reviewed
Oct 31, 2025
| granularity; it is an error to set a value less than one second. By default, | ||
| keep-alive pings are disabled. You should coordinate with the service owner | ||
| before enabling this setting. For example to set a value of 30 seconds to this | ||
| keep-alive pings are disabled. For example to set a value of 30 seconds to this |
There was a problem hiding this comment.
disabled --> no longer true :-)
Also, how does one disable it now?
There was a problem hiding this comment.
Good point. You could disable it by setting something larger than 1000 days, but that's obscure. I added 0 as disabling value.
|
Just curious: Is this in any way related to the experimental gRPC remote executor flag that also mentions keepalive? |
The keepalive is critical for detecting load balancers and other network middlemen that like to silently drop connection data after certain periods of idelness.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keepalive is critical for detecting load balancers and other network middlemen that like to silently drop connection data after periods of idleness.