Skip to content

Commit e6bafe9

Browse files
committed
enable gRPC keepalive by default
The keepalive is critical for detecting load balancers and other network middlemen that like to silently drop connection data after certain periods of idelness.
1 parent 3bee1de commit e6bafe9

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public class AuthAndTLSOptions extends OptionsBase {
116116

117117
@Option(
118118
name = "grpc_keepalive_time",
119-
defaultValue = "null",
119+
defaultValue = "60s",
120120
converter = DurationConverter.class,
121121
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
122122
effectTags = {OptionEffectTag.UNKNOWN},
@@ -126,8 +126,7 @@ public class AuthAndTLSOptions extends OptionsBase {
126126
sends pings after this much time of no read operations on the connection, but
127127
only if there is at least one pending gRPC call. Times are treated as second
128128
granularity; it is an error to set a value less than one second. By default,
129-
keep-alive pings are disabled. You should coordinate with the service owner
130-
before enabling this setting. For example to set a value of 30 seconds to this
129+
keep-alive pings are disabled. For example to set a value of 30 seconds to this
131130
flag, it should be done as this `--grpc_keepalive_time=30s`.
132131
""")
133132
public Duration grpcKeepaliveTime;

0 commit comments

Comments
 (0)