Skip to content

lcm@1.5.2 #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

lcm@1.5.2 #6286

merged 1 commit into from
Oct 23, 2025

Conversation

@jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Oct 23, 2025 •
edited
Loading

This is the first BCR version of https://github.com/lcm-proj/lcm.

Homepage: https://lcm-proj.github.io/lcm/

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (lcm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the lcm module to the Bazel Central Registry, starting with version 1.5.2. The submission includes all necessary files: MODULE.bazel, source.json, presubmit.yml, and metadata.json. The changes adhere to the BCR's contribution guidelines, including being add-only, providing maintainer information, and setting up presubmit checks with both an anonymous module and a test module. The configuration appears correct and complete. Overall, this is a well-formed submission for a new module.

@jwnimmer-tri jwnimmer-tri mentioned this pull request Oct 23, 2025
Closed
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 23, 2025
@Wyverald Wyverald enabled auto-merge (squash) October 23, 2025 22:48
@jwnimmer-tri
Copy link
Contributor Author

@bazel-io skip_check incompatible_flags

I'll work to fix upstream for the next release.

@jwnimmer-tri
Copy link
Contributor Author

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Oct 23, 2025
@Wyverald Wyverald merged commit a8f5acc into bazelbuild:main Oct 23, 2025
17 checks passed
@jwnimmer-tri jwnimmer-tri deleted the lcm branch October 23, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wyverald Wyverald Wyverald approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwnimmer-tri @bazel-io @Wyverald